Add IP-wise transfer filtering and update SSH session protocol#2188
Open
neil-karania wants to merge 10 commits intodrakkan:mainfrom
Open
Add IP-wise transfer filtering and update SSH session protocol#2188neil-karania wants to merge 10 commits intodrakkan:mainfrom
neil-karania wants to merge 10 commits intodrakkan:mainfrom
Conversation
Owner
|
Thank you for the idea and for sharing this WIP PR. We can see how this feature may be useful for certain, more specialized use cases; however, it’s not something we are planning to include in the OSS edition at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2187
Summary
This branch adds source-IP-based transfer scope filtering for file operations, without depending on SFTPGo’s built-in connection allow list.
What this branch changes
SFTPGO_IP_FILTER_ENABLEDallow_unmatcheddeny_unmatcheddata_onlyall_requestsplaceholderSecurity behavior
When the transfer filter is enabled:
SFTPGO_IP_FILTER_MODEImportant fixes included
Example config
Intended use case
This is meant for deployments where access direction depends on network segment, for example:
while preserving normal login flows and avoiding admin lockout.
Caveats
This feature assumes SFTPGo sees the real client IP. If it is deployed behind a reverse proxy, load balancer, or NAT that hides the real source IP, the filtering behavior may not reflect the actual client network.
Checklist for Pull Requests