Add overloaded signing util methods - #649
Conversation
New IPKSigningUtil methods and implementation in both PKFileBasedSigningUtil and PKInMemorySigningUtil that allow callers to provide an OutputStream that the signed pass will be written to. This allows callers to stream the output wherever they want without holding the entire signed pass in memory as a byte array.
|
ooh.. I like that idea. Thanks @josephtaylor |
|
@josephtaylor could you please pull in main again? I fixed the certificate error so tests should pass now |
|
@drallgood apologies for the delay here, just got main merged down into the branch |
|
LGTM ✅ I especially like that this is implemented across both signing util implementations so behavior stays consistent regardless of backing strategy. Nits / follow-ups (non-blocking): Please ensure Javadocs clearly define stream ownership (whether the callee closes the provided OutputStream). |
|
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (81.28%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
============================================
- Coverage 81.37% 81.28% -0.09%
- Complexity 749 753 +4
============================================
Files 59 59
Lines 1648 1662 +14
Branches 58 58
============================================
+ Hits 1341 1351 +10
- Misses 255 259 +4
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
New IPKSigningUtil methods and implementation in both PKFileBasedSigningUtil
and PKInMemorySigningUtil that allow callers to provide an OutputStream that
the signed pass will be written to.
This allows callers to stream the output wherever they want without
holding the entire signed pass in memory as a byte array.