Support iOS 15 devices#14
Open
RasulOs wants to merge 1 commit into
Open
Conversation
- lower iOS deployment target from 16.0 to 15.0 - guard XCUIDevice.hasHardwareButton behind iOS 16 availability - dedupe the test plan/scheme test entries and drop the dangling droidrun-ios-portalTests target reference - remove the hard-coded DEVELOPMENT_TEAM so contributors use local signing - document the iOS 15.0 minimum in the README Keeps FlyingFox at 0.22.0, which builds fine for iOS 15, and keeps the action/camera hardware keys with their existing availability guards. Co-Authored-By: Alvin <alvin_sfb@yahoo.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XCUIDevice.hasHardwareButton(iOS 16+) behind an availability check — the only iOS 16+ API in the codebase.Droidrun Serverwas listed 4x and adroidrun-ios-portalTeststarget that no longer exists in the project was still referenced.DEVELOPMENT_TEAMso contributors use their own local signing settings, as the README already instructs.Supersedes #12 — thanks @vnby for the report, the device validation on iOS 15.8.7, and the scheme/test plan cleanup, which this PR adopts as-is.
Why not the dependency downgrade from #12
Building
mainat deployment target 15.0 with FlyingFox 0.22.0 untouched produces exactly one compile error: thehasHardwareButtonavailability. FlyingFox declares iOS 13+ through 0.22.0, so the 0.16.0 pin, the swift-syntax 509 downgrade, and therun()→start()revert (start()is deprecated in 0.22) are unnecessary. The action/camera hardware keys (4/5) are also kept — their existing#available(iOS 17/18)guards compile fine at target 15, and on iOS 15 they correctly throwunsupportedKeybefore any press is attempted.Validation
xcodebuild build-for-testing -destination generic/platform=iOS(Xcode 26.5, signing disabled):** TEST BUILD SUCCEEDED **with FlyingFox resolved at 0.22.0.generic/platform=iOS Simulator.Package.resolvedis unchanged.Note from #12 for anyone running very old physical devices: Xcode 26.5 appears to have an on-device test-planning regression there; Xcode 26.2 worked.
🤖 Generated with Claude Code