ci: fix double deploy, bump actions#15
Open
lutz-grex wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the cloud-sdk-mcp deploy workflow — kept local (this repo is public and intentionally not on the private shared-workflows):
1. Remove the
pull_request: closedtrigger (deploy bug).A merged PR to
mainfired both thepushevent and thepull_request closedevent → double staging+prod deploy. And since there was nogithub.event.pull_request.mergedguard, closing a PR without merging also deployed to staging+prod. Thepushtrigger alone covers merges. Addedworkflow_dispatchfor manual re-runs instead.2. Bump actions to node24 releases (clears the Node 20 deprecation warnings, runners force Node 24 from June 16): checkout v4→v6, auth v2→v3, setup-buildx v3→v4, build-push v6→v7, get-gke-credentials v2→v3. Same versions already validated across the migrated service repos.
No changes to the branch→environment matrix, vars, or tagging.
🤖 Generated with Claude Code