Add support to look up superclass schemas in inherited controllers#61
Open
keymastervn wants to merge 2 commits intodry-rb:mainfrom
Open
Add support to look up superclass schemas in inherited controllers#61keymastervn wants to merge 2 commits intodry-rb:mainfrom
keymastervn wants to merge 2 commits intodry-rb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am having two classes A and B with the following definitions
The problem is, B couldn't inherit the
schema(:index)defined in the parent controller A, so I have to go with the reuse schema approach. It is even trickier because our ApplicationController has a callback to verify input and exits earlyIn order to get the dry-schema object from the parent class, this PR checks if the parent class is including the SafeParams module, it then merges the parent schemas to resolve the
safe_paramsfor the action.