Fix JNI code generation issues for Boolean return types, top-level functions, and visibility#15
Open
peacefulprogram wants to merge 1 commit into
Open
Fix JNI code generation issues for Boolean return types, top-level functions, and visibility#15peacefulprogram wants to merge 1 commit into
peacefulprogram wants to merge 1 commit into
Conversation
…l function returns Boolean. 2. Fix incorrect JNI native function names for top-level functions defined in lowercase-named files. 3. Make generated JVM external functions private, and preserve the visibility of generated JVM actual declarations.
Owner
|
Hi thank you for the contribution! That branch also fixes some issues with top level functions and boolean conversion. |
Owner
I believe that's the default behavior when creating top level functions inside a file with non capitalized name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first character of the generated Java class name is always uppercase.