feat: support OR pushdown + add clustered data tests - #292
Open
eeroel wants to merge 2 commits into
Open
Conversation
eeroel
marked this pull request as draft
March 14, 2026 09:32
This comment was marked as outdated.
This comment was marked as outdated.
eeroel
commented
Mar 14, 2026
| if (should_report_explain_output) { | ||
| if (!mfr_info->extra_info.total_files.IsValid()) { | ||
| mfr_info->extra_info.total_files = old_total; | ||
| } else if (mfr_info->extra_info.total_files.GetIndex() != old_total) { |
Author
There was a problem hiding this comment.
Not sure about this, but OR-filtered queries will hit this branch
eeroel
marked this pull request as ready for review
March 14, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
OR filter pushdown is now available via Delta Kernel -> support that.
Also adding tests for data that is perfectly clustered (one unique value per file) but not partitioned.
Potential issues:
generate_test_data_delta_rsto support writing such "mixed" tables though.