Fix CVE-2023-46308: remove vulnerable plotly.js 1.58.5#7040
Open
arijitroy003 wants to merge 1 commit into
Open
Fix CVE-2023-46308: remove vulnerable plotly.js 1.58.5#7040arijitroy003 wants to merge 1 commit into
arijitroy003 wants to merge 1 commit into
Conversation
… 3.0.1 plotly-1.58.5.min.js is affected by CVE-2023-46308 (prototype pollution via crafted plot config or attributes). The repo already ships plotly-cartesian-3.0.1.min.js which is not affected, so this commit switches the one remaining consumer (benchmarks-over-time blog post) to that bundle, updates Plotly.plot() calls to Plotly.newPlot() (the v1 API was removed in Plotly.js v2), and deletes the vulnerable file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js/plotly-1.58.5.min.jsis vulnerable to prototype pollution via crafted plot config or attributesjs/plotly-cartesian-3.0.1.min.js(used by the sorting blog post), which is not affected_posts/2024-06-26-benchmarks-over-time.md) to use the existingplotly-cartesian-3.0.1.min.jsbundlePlotly.plot()calls toPlotly.newPlot()(the v1 API was removed in Plotly.js v2)js/plotly-1.58.5.min.jsTest plan
plotly-1.58.5