This repository was archived by the owner on Mar 12, 2025. It is now read-only.
refactor: Use &self instead of &mut when possible#1045
Draft
kdy1 wants to merge 34 commits intodudykr:mainfrom
Draft
refactor: Use &self instead of &mut when possible#1045kdy1 wants to merge 34 commits intodudykr:mainfrom
&self instead of &mut when possible#1045kdy1 wants to merge 34 commits intodudykr:mainfrom
Conversation
|
Thank you for the PR! Files to checkThese are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message. You can run |
kdy1
changed the title
&self instead of &mut where possible&self instead of &mut when possible
kdy1
force-pushed
the
self-mut
branch
4 times, most recently
from
1b68fad to
0c0251f
Compare
Member
Author
|
Status: I did lots of work, but I'm stuck. I may need to split all call/new into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is required for #1042, which requires to recurse into self.
Related issue (if exists):