This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Check reserved identifiers in function params#129
Open
littledivy wants to merge 1 commit intodudykr:mainfrom
Open
Check reserved identifiers in function params#129littledivy wants to merge 1 commit intodudykr:mainfrom
littledivy wants to merge 1 commit intodudykr:mainfrom
Conversation
littledivy
commented
Oct 28, 2022
Comment on lines
+485
to
+486
| // TODO(@littledivy): Generalize this to work regardless of 'function' context. | ||
| fn validate_parameter_name(ctx: &mut Analyzer, p: &RParam, is_async: bool, is_generator: bool) { |
Contributor
Author
There was a problem hiding this comment.
This should be made context-aware so it can be used with in top level and not just function params. Maybe in the parser? I saw @kdy1 that you have a similar TODO a few lines above.
Member
There was a problem hiding this comment.
I think it's better to make a method of Analyzer for consistency.
I may refactor it to split the analyzer, but let's use a method at now
Member
|
Also, I think this should be handled by the parser. TS1xxx errors are for parser/lexer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TS1359 validation for function parameter identifiers.
New passing conforming tests: