Update Id3v2.php#19
Open
za-ek wants to merge 4 commits into
Open
Conversation
utf8_encode corrupts cp1251 strings
Owner
|
Hi @za-ek, thanks for your PR but I'm afraid this breaks the functionality of the library (if you run the unit tests you'll see Please can you provide a unit test demonstrating the issue you're experiencing, then we can find the best way to fix it without introducing any regressions |
Author
|
ah sorry I didn't see there is a test folder. Do you mean I make a PR with a test? |
Owner
You can just push it to this PR, or if you're struggling with a test just any script/snippet I can use to reproduce the problem you're trying to fix |
Author
|
I add mp3 file and test so now you can reproduce the problem |
Author
|
btw you can add this line after line 166 in Id3v2.php file to fix test you mentioned: $value = Bom::removeBom($value); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utf8_encode corrupts cp1251 strings