Skip to content

Update Id3v2.php#19

Open
za-ek wants to merge 4 commits into
duncan3dc:mainfrom
za-ek:patch-1
Open

Update Id3v2.php#19
za-ek wants to merge 4 commits into
duncan3dc:mainfrom
za-ek:patch-1

Conversation

@za-ek

@za-ek za-ek commented Nov 3, 2022

Copy link
Copy Markdown

utf8_encode corrupts cp1251 strings

utf8_encode corrupts cp1251 strings
@duncan3dc

Copy link
Copy Markdown
Owner

Hi @za-ek, thanks for your PR but I'm afraid this breaks the functionality of the library (if you run the unit tests you'll see Id3v2Test::testUtf16WithoutBom fails).

Please can you provide a unit test demonstrating the issue you're experiencing, then we can find the best way to fix it without introducing any regressions

@za-ek

za-ek commented Nov 3, 2022

Copy link
Copy Markdown
Author

ah sorry I didn't see there is a test folder. Do you mean I make a PR with a test?

@duncan3dc

Copy link
Copy Markdown
Owner

Do you mean I make a PR with a test?

You can just push it to this PR, or if you're struggling with a test just any script/snippet I can use to reproduce the problem you're trying to fix

@za-ek

za-ek commented Nov 3, 2022

Copy link
Copy Markdown
Author

I add mp3 file and test so now you can reproduce the problem

@za-ek

za-ek commented Nov 3, 2022

Copy link
Copy Markdown
Author

btw you can add this line after line 166 in Id3v2.php file to fix test you mentioned:

$value = Bom::removeBom($value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants