Ability to refresh Plex Live TV Guide after the channels.json file is updated#40
Draft
hdonapati wants to merge 18 commits intoduncanleo:masterfrom
Draft
Ability to refresh Plex Live TV Guide after the channels.json file is updated#40hdonapati wants to merge 18 commits intoduncanleo:masterfrom
channels.json file is updated#40hdonapati wants to merge 18 commits intoduncanleo:masterfrom
Conversation
Co-authored-by: Duncan Leo <hello@duncanleo.me>
duncanleo
reviewed
Nov 23, 2024
| @@ -1,4 +1,4 @@ | |||
| module github.com/duncanleo/plex-dvr-hls | |||
| module plex-dvr-hls | |||
Owner
There was a problem hiding this comment.
nit: This change isn't compliant with Go module naming conventions:
The Go standard library uses package paths that do not contain a dot in the first path element, and the go command does not attempt to resolve such paths from network servers.
The non-absolute naming system appears to be suitable for local sub-packages (e.g. config) but not the root package.
|
|
||
| func RefreshPlexLiveTVGuide() error { | ||
| for _, server := range Cfg.PlexServers { | ||
| url := server.Endpoint + "/livetv/dvrs/29/reloadGuide?X-Plex-Token=" + server.Token |
Owner
There was a problem hiding this comment.
nit: is the ID 29 hardcoded? I think it may change (e.g. if the DVR is removed and re-added).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.example.jsonto show example forplex_servers.channels.goandconfig.gohas the actual changes to refresh the Plex Server Live TV Guide when channels are updated.@duncanleo Can you please review this PR.