Test FMultiSelect highlight follows the last tapped item (#1055)#1065
Merged
Conversation
Regression test for #1055: on touch, a quick tap must move the highlight to the tapped item instead of leaving it on the first (autofocused) item. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
Follow-up to the #1055 fix, which shipped bundled in #1061 without a regression test or changelog entry. This PR backfills both.
multi_select_test.dart) for Only one(most probably first) selected item in theFMultiSelectwidget is highlighted #1055: on touch, a quick tap must move the highlight to the tapped item instead of leaving it on the first (autofocused) item. Verified TDD-style — it fails against the pre-fix logic at the second-tap assertion and passes with the fix.CHANGELOG.mdentry under the unreleasedFSelect&FMultiSelectsection documenting the fix.select_item.dartto explain why focus is moved inonPress(thepressedvariant is debounced, so the press branch never fires on a quick tap) rather than inonVariantChange.sandbox.dartdown toFSelect+FMultiSelectfor manually exercising this behavior.Closes #1055.
Checklist