update NamerInterface signature - #1561
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the type hints in two naming interfaces to accept both objects and arrays for the $object parameter. The changes align the interface signatures with their implementations, which already support both types.
- Updated PHPStan templates to
object|arrayin both interfaces - Updated method signature in
NamerInterface::name()to acceptobject|array - Removed deprecation notice from docblock in
NamerInterface
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Naming/NamerInterface.php | Updated name() method signature and PHPStan template to accept `object |
| src/Naming/DirectoryNamerInterface.php | Updated PHPStan template to accept `object |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -9,7 +9,7 @@ | |||
| * | |||
| * @author Kevin bond <kevinbond@gmail.com> | |||
There was a problem hiding this comment.
Author name 'Kevin bond' should be capitalized as 'Kevin Bond'.
Suggested change
| * @author Kevin bond <kevinbond@gmail.com> | |
| * @author Kevin Bond <kevinbond@gmail.com> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1546