馃帹 fix coding standard - #1576
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies coding standard fixes, primarily enforcing the use of static keyword on closures/arrow functions in test files as required by the PHP-CS-Fixer configuration (@Symfony rule), and also updates the PHP 8.5 Dockerfile with a corrected base image tag and a bumped MongoDB extension version.
Changes:
- Added
statickeyword to arrow function callbacks in test files to comply with the@SymfonyPHP-CS-Fixer rule. - Fixed the PHP 8.5 Docker base image from
php:8.5.0-alpine(non-existent tag) tophp:8.5-alpine(floating minor version tag). - Bumped the MongoDB PECL extension version in
Dockerfile85from2.1.4to2.1.8.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/Handler/UploadHandlerTest.php |
Adds static to arrow function in expectEvents() to satisfy the coding standard. |
tests/Form/Type/VichFileTypeTest.php |
Adds static to arrow function in testBuildView() to satisfy the coding standard. |
docker/Dockerfile85 |
Corrects PHP 8.5 base image tag and bumps the MongoDB PECL extension version. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.