Skip to content

馃帹 fix coding standard - #1576

Merged
garak merged 1 commit into
dustin10:masterfrom
garak:fix-cs
Mar 1, 2026
Merged

馃帹 fix coding standard#1576
garak merged 1 commit into
dustin10:masterfrom
garak:fix-cs

Conversation

@garak

@garak garak commented Feb 28, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 28, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies coding standard fixes, primarily enforcing the use of static keyword on closures/arrow functions in test files as required by the PHP-CS-Fixer configuration (@Symfony rule), and also updates the PHP 8.5 Dockerfile with a corrected base image tag and a bumped MongoDB extension version.

Changes:

  • Added static keyword to arrow function callbacks in test files to comply with the @Symfony PHP-CS-Fixer rule.
  • Fixed the PHP 8.5 Docker base image from php:8.5.0-alpine (non-existent tag) to php:8.5-alpine (floating minor version tag).
  • Bumped the MongoDB PECL extension version in Dockerfile85 from 2.1.4 to 2.1.8.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/Handler/UploadHandlerTest.php Adds static to arrow function in expectEvents() to satisfy the coding standard.
tests/Form/Type/VichFileTypeTest.php Adds static to arrow function in testBuildView() to satisfy the coding standard.
docker/Dockerfile85 Corrects PHP 8.5 base image tag and bumps the MongoDB PECL extension version.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker/Dockerfile85
@garak
garak merged commit ed584d7 into dustin10:master Mar 1, 2026
17 checks passed
@garak
garak deleted the fix-cs branch March 1, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants