Initialize nullable promoted file properties on load - #1602
Draft
tomatotomata wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1411
When a nullable uploadable field is constructor-promoted, Doctrine can hydrate the entity without running its constructor. If no stored filename exists, the injector previously skipped the setter, leaving the promoted property uninitialized and causing an UninitializedPropertyException on access.
This change explicitly writes null on the no-path branch and allows PropertyMapping::setFile() to accept nullable files. The regression test exercises an instance created without its constructor and verifies the getter returns null after injection.
Verification:
The scope follows the solution proposed by the issue reporter and the collaborator response there: #1411 (comment)