test(launchpad): 🧪 adding docker files to test old Ubuntu distros #89#123
Draft
dvorka wants to merge 2 commits into
Draft
test(launchpad): 🧪 adding docker files to test old Ubuntu distros #89#123dvorka wants to merge 2 commits into
dvorka wants to merge 2 commits into
Conversation
dvorka
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a set of Docker-based, per-Ubuntu-release packaging tests intended to validate that the Ubuntu .deb can be built and installed on older Ubuntu distros (trusty/xenial/bionic/focal), matching the concern raised in #89 about legacy toolchains (e.g., debhelper compat 9).
Changes:
- Added Makefile targets to build and run Ubuntu-specific Docker images that build+install the
.debon each target Ubuntu release. - Introduced Ubuntu Docker build/run scripts and a Dockerfile that performs an end-to-end package build+install at image build time.
- Added a
debian/overlay (compat 9 + simplified rules/control) to make package builds work on legacy Ubuntu releases.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds test-ubuntu-* targets to build/run release-specific Ubuntu Docker tests. |
| build/docker/ubuntu/build.sh | Builds a per-release Ubuntu image from a clean working-tree build context + debian overlay. |
| build/docker/ubuntu/run.sh | Runs the per-release Ubuntu container and maps host storage + ports for manual testing. |
| build/docker/ubuntu/Dockerfile | Builds and installs the .deb inside an Ubuntu:${release} image and configures runtime env. |
| build/docker/ubuntu/apt-setup.sh | Makes apt-get update work on EOL Ubuntu releases by switching to old-releases. |
| build/docker/ubuntu/debian-overlay/rules | Legacy-compatible debian rules using uv to build wheels and generate requirements. |
| build/docker/ubuntu/debian-overlay/control | Legacy-compatible Debian control metadata (debhelper compat 9). |
| build/docker/ubuntu/debian-overlay/compat | Sets debhelper compatibility level to 9. |
| build/docker/ubuntu/debian-overlay/source/format | Sets source format to 3.0 (native) for local Docker test builds. |
|
|
||
| docker run \ | ||
| --name "${CONTAINER_NAME}" \ | ||
| --publish 8888:5000 \ |
Comment on lines
+51
to
+55
| # | ||
| # Keys — for production set these in the environment before running | ||
| # | ||
| ENC_KEY="${MYTRAL_ENCRYPTION_KEY:-docker-dev-key-change-me}" | ||
|
|
Comment on lines
+57
to
+61
| BUILD_CTX="/tmp/mytral-docker-ubuntu-${RELEASE}-build" | ||
| echo " Build ctx: ${BUILD_CTX}" | ||
|
|
||
| rm -rf "${BUILD_CTX}" | ||
| mkdir -p "${BUILD_CTX}" |
Comment on lines
+63
to
+65
| RUN curl -LsSf \ | ||
| "https://github.com/astral-sh/uv/releases/download/${UV_VERSION}/uv-x86_64-unknown-linux-gnu.tar.gz" \ | ||
| | tar -xz -C /usr/local/bin --strip-components=1 uv-x86_64-unknown-linux-gnu/uv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.