Skip to content

enh(welcome): 🌟 improving the first login experience on DESKTOP incarnation #128#131

Merged
dvorka merged 5 commits into
dev/1.58.0from
feat-128/auto-usr-and-login
Jul 6, 2026
Merged

enh(welcome): 🌟 improving the first login experience on DESKTOP incarnation #128#131
dvorka merged 5 commits into
dev/1.58.0from
feat-128/auto-usr-and-login

Conversation

@dvorka

@dvorka dvorka commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

@dvorka dvorka requested a review from Copilot July 5, 2026 16:31
@dvorka dvorka self-assigned this Jul 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the first-run and login flow for the DESKTOP incarnation by bootstrapping a default user when no profiles exist and enabling a smoother auto-login experience, with documentation and test coverage updates.

Changes:

  • Add desktop bootstrap that auto-creates a default athlete user with auto-login enabled when no profiles exist.
  • Add desktop-only /login auto-login when exactly one auto-login-enabled profile exists, and suppress that auto-login after logout until an explicit login/sign-up.
  • Extend dataset registration to persist an auto_login flag, with new/updated tests and installation/changelog documentation updates.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_dataset.py Adds a regression test ensuring register_new_user(..., auto_login=...) persists to the profile.
tests/test_bootstraps.py Adds tests for default desktop user bootstrap behavior (create vs no-op).
tests/test_auth_uri_space.py Adds tests for desktop auto-login on GET /login and suppression behavior after logout.
mytral/static/documentation/installation.html Documents the desktop “first launch” auto-create/auto-login behavior.
mytral/static/documentation/changelog.html Updates the rendered changelog with the new desktop first-start behavior and a Snap fix note.
mytral/run_desktop.py Updates desktop run commentary to reflect the new default user and logout suppression.
mytral/routes.py Introduces COOKIE_AUTO_LOGIN_SUPPRESSED session key constant.
mytral/commons.py Adds desktop default user constants (athlete, display name, password).
mytral/bootstraps.py Adds bootstrap_default_desktop_user() to create the initial desktop account when no users exist.
mytral/blueprints/auth_uri_space.py Implements desktop auto-login on GET /login, clears suppression on explicit login/sign-up, and sets suppression on logout.
mytral/backends/datasets/dataset_json.py Extends register_new_user() to persist auto_login into the created profile.
mytral/backends/dataset.py Updates the UserDataset.register_new_user() abstract interface to include user_display_name and auto_login.
mytral/__init__.py Invokes desktop bootstrap during app singleton initialization when incarnation is DESKTOP.
INSTALLATION.md Documents desktop first-launch behavior in Markdown.
docs/INSTALLATION.md Mirrors the installation doc update under docs/.
docs/CHANGELOG.md Updates Markdown changelog with the new desktop first-start behavior and Snap fix note.
CHANGELOG.md Updates root Markdown changelog with the same release notes.

Comment thread mytral/blueprints/auth_uri_space.py
Comment thread mytral/bootstraps.py
Comment thread mytral/commons.py
@dvorka dvorka marked this pull request as draft July 5, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Comment thread mytral/blueprints/auth_uri_space.py Outdated
Comment thread mytral/commons.py Outdated
Comment thread mytral/commons.py
@dvorka dvorka marked this pull request as ready for review July 6, 2026 09:32
@dvorka dvorka merged commit 6299e34 into dev/1.58.0 Jul 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] automatically create user & log-in (if 1 user) in DESKTOP incarnation

2 participants