enh(welcome): 🌟 improving the first login experience on DESKTOP incarnation #128#131
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the first-run and login flow for the DESKTOP incarnation by bootstrapping a default user when no profiles exist and enabling a smoother auto-login experience, with documentation and test coverage updates.
Changes:
- Add desktop bootstrap that auto-creates a default
athleteuser with auto-login enabled when no profiles exist. - Add desktop-only
/loginauto-login when exactly one auto-login-enabled profile exists, and suppress that auto-login after logout until an explicit login/sign-up. - Extend dataset registration to persist an
auto_loginflag, with new/updated tests and installation/changelog documentation updates.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_dataset.py |
Adds a regression test ensuring register_new_user(..., auto_login=...) persists to the profile. |
tests/test_bootstraps.py |
Adds tests for default desktop user bootstrap behavior (create vs no-op). |
tests/test_auth_uri_space.py |
Adds tests for desktop auto-login on GET /login and suppression behavior after logout. |
mytral/static/documentation/installation.html |
Documents the desktop “first launch” auto-create/auto-login behavior. |
mytral/static/documentation/changelog.html |
Updates the rendered changelog with the new desktop first-start behavior and a Snap fix note. |
mytral/run_desktop.py |
Updates desktop run commentary to reflect the new default user and logout suppression. |
mytral/routes.py |
Introduces COOKIE_AUTO_LOGIN_SUPPRESSED session key constant. |
mytral/commons.py |
Adds desktop default user constants (athlete, display name, password). |
mytral/bootstraps.py |
Adds bootstrap_default_desktop_user() to create the initial desktop account when no users exist. |
mytral/blueprints/auth_uri_space.py |
Implements desktop auto-login on GET /login, clears suppression on explicit login/sign-up, and sets suppression on logout. |
mytral/backends/datasets/dataset_json.py |
Extends register_new_user() to persist auto_login into the created profile. |
mytral/backends/dataset.py |
Updates the UserDataset.register_new_user() abstract interface to include user_display_name and auto_login. |
mytral/__init__.py |
Invokes desktop bootstrap during app singleton initialization when incarnation is DESKTOP. |
INSTALLATION.md |
Documents desktop first-launch behavior in Markdown. |
docs/INSTALLATION.md |
Mirrors the installation doc update under docs/. |
docs/CHANGELOG.md |
Updates Markdown changelog with the new desktop first-start behavior and Snap fix note. |
CHANGELOG.md |
Updates root Markdown changelog with the same release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: