build(macos): 🏗️ adding macOS .dmg for arm64 - GHA workflow, Makefile targets and artifacts #111#132
Draft
dvorka wants to merge 1 commit into
Draft
build(macos): 🏗️ adding macOS .dmg for arm64 - GHA workflow, Makefile targets and artifacts #111#132dvorka wants to merge 1 commit into
dvorka wants to merge 1 commit into
Conversation
dvorka
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a macOS .dmg distribution path for the MyTraL desktop app, including local Makefile targets, macOS build scripts (PyInstaller -> .app -> .dmg), and a GitHub Actions workflow to produce a DMG artifact for release PRs.
Changes:
- Add macOS DMG build/clean/install Makefile targets and wire them into the macOS release distro target.
- Introduce
build/macos-dmg/*scripts to buildMyTraL.appvia PyInstaller and package it into a.dmg. - Add a dedicated GitHub Actions workflow to build and upload the DMG artifact on release PRs; update docs/changelog with macOS DMG instructions.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds install/build links for macOS DMG (currently points to the wrong INSTALLATION file). |
| Makefile | Adds macOS DMG targets and includes them in release-distros-macos. |
| docs/INSTALLATION.md | Documents macOS DMG install and build steps, including Gatekeeper workaround. |
| CHANGELOG.md | Notes the addition of macOS DMG distribution and where to find it in CI artifacts. |
| build/macos-dmg/create-spec.sh | Creates a PyInstaller spec tailored for a macOS .app bundle build. |
| build/macos-dmg/build-app.sh | Builds MyTraL.app on macOS (arm64) using PyInstaller and generated .icns. |
| build/macos-dmg/build-dmg.sh | Packages MyTraL.app into a distributable .dmg via hdiutil. |
| build/macos-dmg/clean.sh | Cleans macOS DMG build artifacts and generated outputs. |
| build/macos-dmg/.gitignore | Ignores generated spec/icon files for macOS DMG builds. |
| .github/workflows/distro-macos-dmg.yml | Builds the DMG on macos-latest for rel/* PRs and uploads it as an artifact (path resolution currently fragile). |
| * [Ubuntu (PPA)](INSTALLATION.md#install-on-ubuntu-from-ppa) | ||
| * [Windows (installer)](INSTALLATION.md#install-on-windows-using-installer) | ||
| * [Windows (zip)](INSTALLATION.md#install-on-windows-using-zip) | ||
| * [macOS (dmg)](INSTALLATION.md#install-on-macos-using-dmg) |
| * [Flatpak (bundle)](INSTALLATION.md#build-flatpak-on-linux) | ||
| * [Windows (installer)](INSTALLATION.md#build-windows-installer) | ||
| * [Windows (binary)](INSTALLATION.md#build-binary-on-windows) | ||
| * [macOS (dmg)](INSTALLATION.md#build-macos-dmg) |
| powershell.exe -NoProfile -ExecutionPolicy Bypass -Command "Remove-Item -Recurse -Force distro\windows -ErrorAction SilentlyContinue; Write-Host 'DONE: Windows installer artifacts removed'" | ||
|
|
||
| # | ||
| # MACOS: macOS .dmg distribution (Apple Silicon / arm64 only, local builds only) |
Comment on lines
+60
to
+62
| BUNDLE=$(ls distro/macos-dmg/mytral-*.dmg) | ||
| echo "path=${BUNDLE}" >> "$GITHUB_OUTPUT" | ||
| echo "name=$(basename "${BUNDLE}")" >> "$GITHUB_OUTPUT" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: