Define point-in-time stock universe foundation - #10
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba940514d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| No new stock model will be trained until the universe contract passes or reports a transparent | ||
| coverage limitation that can be accepted in advance. |
There was a problem hiding this comment.
Remove the coverage-limitation bypass
If the coverage audit finds an unresolved gap, this wording permits training once someone accepts the limitation, directly contradicting the plan's fail-closed rules and terminal requirement that the contract actually pass before training. That exception can allow survivorship-biased or incomplete dates into the next experiment; require a passing, frozen contract here as well, or define a formal contract version that excludes the affected period and then passes all gates.
Useful? React with 👍 / 👎.
| - active index membership under the effective-dated ledger; | ||
| - at least 252 prior eligible trading sessions of price history; | ||
| - a valid close and volume observation at the decision cutoff; |
There was a problem hiding this comment.
Fail qualification before filtering missing observations
When an active constituent lacks its cutoff close or volume, this predicate makes the security ineligible, while the later fail-closed rule only rejects missing prices for an already "eligible" security. An implementation following these definitions can therefore silently drop the missing-data constituent instead of failing the date, reintroducing data-availability or survivorship bias; define membership-qualified candidates first and make missing required observations an explicit qualification failure before applying liquidity and price filters.
Useful? React with 👍 / 👎.
Summary
README.mddocs/point_in_time_stock_universe_plan.mdBenchmark narrative
The README figures were checked against the frozen full-period table in
docs/research_history.md; no historical strategy research was rerun and no result was changed.Boundary
Design documentation only. This PR does not fetch data, train a model, run a backtest, create a portfolio, or add executable research behavior.
Changed files
README.mddocs/point_in_time_stock_universe_plan.mdValidation
docs/research_history.mdgit diff --check: passed