Open
Conversation
- Hide the phil blob - Add first two controls, uc and sg - Add sync code between phil str and controls - Add Edit Phil dialog
Includes more validation as well, such as the unit cell being compatible with the space group
- Remove extra ok/cancel - Add min spots for hitfinding - Fix rounding in unit cell and roundtripping of phil using working phil
(from pyana)
Co-authored-by: Aaron Brewster <asbrewster@lbl.gov>
…sses When the GUI is launched with a custom settings file, command-line tools run afterward now correctly use the same settings file. The GUI launcher sets CCTBX_XFEL_SETTINGS environment variable, which inherits to child processes. Both load_cached_settings() and save_cached_settings() check this environment variable first, falling back to the default behavior if not set. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Users set CCTBX_XFEL_SETTINGS environment variable directly to specify a custom settings file. All tools (GUI and command-line) read this environment variable. Removed command-line argument parsing for settings files to keep the implementation simple with a single mode of operation. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add drive.lock_file phil parameter to allow users to specify a lock file location when the home directory is not writable (e.g., on compute nodes). Changes: - Add drive.lock_file phil parameter (default None) - Modify Locker class to accept configurable path - Pass lock_file through pydrive2_interface to Locker - Default behavior unchanged (uses ~/.upload_mtz.lock when None) This fixes issues on systems where home directories are not writable from compute nodes, allowing users to specify an alternative writable location. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…o xfel_gui_project_management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experimental PR 1: accumulated changes from NERSC