chore: Making variables "snake_case" in drag and drop code - #419
Merged
Conversation
LuchoTurtle
added
in-progress
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 599 599
=========================================
Hits 599 599
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
Should be mergeable 🆗 |
LuchoTurtle
added
awaiting-review
nelsonic
reviewed
Sep 10, 2023
Member
|
Hi @LuchoTurtle the only reason I didn't merge this immediately is that it will create |
nelsonic
approved these changes
Sep 16, 2023
nelsonic
left a comment
nelsonic
left a comment
Member
There was a problem hiding this comment.
Changed the target branch to items-list and confirmed no merge-conflicts. ✅
Thanks again for updating the variable names. 🙏
Merging. 
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #416
This renames events and variables in
assets/js/app.js,lib/app_web/live/app_live.exandlib/app_web/live/app_live.html.heex, as well as the respective tests.BUILDIT.mdhas also been modified according to these changes.