Skip to content

⚡ Optimize font handle cloning in update_circle_layout loop #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dynamikdev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Optimize font handle cloning in update_circle_layout loop #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/ui/systems.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ pub fn update_circle_layout(
// Use minimum dimension for radius to ensure it fits comfortably with padding.
let radius = available_width.min(available_height) / 2.0 * 0.8;
// Scale font size linearly based on the radius to maintain visual proportions.
let dynamic_font_size = radius * 0.25;
let font_size = (radius * 0.25).max(10.0);
let font_handle = typography.space_grotesk.clone();

for (index, mut transform, mut text_font) in &mut text_query {
let i = index.0;
Expand All @@ -210,8 +211,16 @@ pub fn update_circle_layout(
transform.translation.x = x - PANEL_WIDTH / 2.0;
transform.translation.y = y;
transform.translation.z = 1.0;
text_font.font = typography.space_grotesk.clone();
text_font.font_size = dynamic_font_size.max(10.0); // Ensure readability on small windows.

// Optimize: Only update font and size if they have actually changed.
// This avoids unnecessary atomic operations from Handle cloning and
// unnecessary component mutations.
if text_font.font_size != font_size {
text_font.font_size = font_size;
}
if text_font.font != font_handle {
text_font.font = font_handle.clone();
}
}
}

Expand Down