Fix slip calculation in DryFrictionWheelJoint#252
Open
juliusaka wants to merge 1 commit intodzimmer:masterfrom
Open
Fix slip calculation in DryFrictionWheelJoint#252juliusaka wants to merge 1 commit intodzimmer:masterfrom
juliusaka wants to merge 1 commit intodzimmer:masterfrom
Conversation
The previous implementation lead to an error because of 1/sqrt(0) in Dymola 2025x using the dassl solver.
Author
|
We (@lmikelsons and me) did some more research about this. This isn't a problem due to 2025x, its about the analytic Jacobian calculation (which I turned on Dymola 2025x). For the case with the 0.0001 outside the brackets of sqrt, within the Jacobian section we have which can lead to a division by zero error: With the 0.0001^2 inside the brackets, we get in the Jacobian section and the model runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation lead to an error because of 1/sqrt(0) in Dymola 2025x using the dassl solver.