fix: prevent page overflow from 100vh layout#68
Open
t128n wants to merge 1 commit into
Open
Conversation
43081j
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructures the page layout so individual
.pageelements no longer rely on100vh.The previous layout caused vertical overflow because
100vhdid not account for surrounding padding and Controls component. This PR moves the full-height behavior into the main layout wrapper and lets pages fill the remaining space via flex growth.Screenshots
//package-json/packages/<package>@eslint/eslinteslint/eslintNo visual discrepancies seen in testing.
The scrollbar is not visible in the screenshots because it auto-hides. However, in production the page can still be scrolled even though there is no additional content to scroll to.