fix: pi.sendUserMessage/sendMessage return Promise#5752
Closed
steptian wants to merge 1 commit into
Closed
Conversation
Both sendMessage() and sendUserMessage() in createExtensionAPI() and the runtime sendUserMessage binding did not return their underlying Promise. This caused extensions' await calls to resolve immediately (~1ms), leaving the agent in streaming state when print-mode's session.prompt() was called next. Fixes: earendil-works#5751
Contributor
|
This PR was auto-closed. Only contributors approved with Maintainers review auto-closed issues daily. Issues that do not meet the quality bar in CONTRIBUTING.md will not be reopened or receive a reply. If a maintainer replies See CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pi.sendUserMessage()andpi.sendMessage()in the extension API do not return their underlying Promise. This meansawait pi.sendUserMessage(...)resolves immediately (after ~1ms) instead of waiting for the agent to finish.Impact
In print mode (
pi -p), extensions that callpi.sendUserMessage()insession_starthooks cause a race condition where print-mode'ssession.prompt()seesisStreaming === trueand throws:This breaks subagent calls and any print-mode usage.
Fix
Two missing
returnstatements:packages/coding-agent/src/core/extensions/loader.ts:sendMessage()andsendUserMessage()delegate to runtime but don't return the Promise.packages/coding-agent/src/core/agent-session.ts:The runtime
sendUserMessagebinding also drops the Promise.Closes #5751