Add files via upload#5776
Closed
Paramveersingh-S wants to merge 1 commit into
Closed
Conversation
Contributor
|
This PR was auto-closed. Only contributors approved with Maintainers review auto-closed issues daily. Issues that do not meet the quality bar in CONTRIBUTING.md will not be reopened or receive a reply. If a maintainer replies See CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix Agent Wedge on Unresponsive Streams & Tool Executions
Fixes Issue #2381
Description
This PR addresses the issue where
pi-agent-corecan hang indefinitely if the underlying LLM provider stream stops yielding events without closing, or if a tool'sexecute()promise never resolves.This introduces configurable timeouts for both boundaries:
AgentLoopConfig.streamTimeoutMs: Timeouts the stream if no event is yielded. (Default 5 mins).AgentLoopConfig.toolTimeoutMs: Timeouts the overall tool execution. (Default 10 mins).AgentTool.timeoutMs: Override for specific tools.If a timeout occurs, the stream or tool execution throws a timed-out error, allowing the loop to gracefully report the error to the UI and either continue or exit instead of hanging dead.
Changes
packages/agent/src/types.tsto addstreamTimeoutMsandtoolTimeoutMstoAgentLoopConfig, andtimeoutMstoAgentTool.packages/agent/src/agent-loop.tsto usePromise.racefor timeouts on the assistant streamiterator.next()and toolexecute().