fix(tui): restore cursorUp line-start jump before history browsing#5789
Merged
vegarsti merged 1 commit intoJun 16, 2026
Merged
Conversation
b62ec52 to
0d10cb6
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1050 added editor boundary behavior where pressing Up on the first visual line of non-empty input jumps to the start of the line instead of doing nothing. Commit
e4907b3bfixed draft restoration for prompt-history browsing, but changedcursorUpto always enter history whenever history exists. That made the start-of-line jump path unreachable for non-empty input with history.This keeps both behaviors:
e4907b3bis preserved: after entering history from a draft, Down restores the draft state.Tests were updated to cover the two-step non-empty flow: first Up jumps to the start of the draft, second Up enters history, and Down restores the draft.