ClientContext.h: Prevent double free by checking in wrapper#3377
Draft
functionpointer wants to merge 1 commit intoearlephilhower:masterfrom
Draft
ClientContext.h: Prevent double free by checking in wrapper#3377functionpointer wants to merge 1 commit intoearlephilhower:masterfrom
functionpointer wants to merge 1 commit intoearlephilhower:masterfrom
Conversation
This work in progress commit adds NULL checks in lwip_wrap.cpp to prevent double frees in ClientContext.h See earlephilhower#3265 and earlephilhower#3368 It is alternative to earlephilhower#3370
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds NULL checks in lwip_wrap.cpp to prevent double frees in ClientContext.h
See #3265 and #3368
It is an alternative to #3370
As mentioned in #3368 (comment), this is currently incomplete as it does not all accesses of pcb go through the wrapper.