Add BREAK detection to SerialPIO, fix parity for < 8 bits#3406
Merged
earlephilhower merged 3 commits intomasterfrom Mar 23, 2026
Merged
Add BREAK detection to SerialPIO, fix parity for < 8 bits#3406earlephilhower merged 3 commits intomasterfrom
earlephilhower merged 3 commits intomasterfrom
Conversation
Fixes #3403 and reduced PIO program by 1 instruction
Mask off value so only data bits checked, not parity or stop
earlephilhower
changed the title
Evidently you can assign an into to a bool without getting a warning in GCC with `-Werror -Wextra`. D'oh.
habazut
added a commit
to DCC-EX/RCSerialPIO
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3403 and reduced PIO program by 1 instruction