response body from image+url request for better error reporting #2334#2350
Open
mithrandirii wants to merge 2 commits intoeclipse-birt:masterfrom
Open
response body from image+url request for better error reporting #2334#2350mithrandirii wants to merge 2 commits intoeclipse-birt:masterfrom
mithrandirii wants to merge 2 commits intoeclipse-birt:masterfrom
Conversation
…se-birt#2334 Added response body to failed responses in ResourceLocatorWrapper
mithrandirii
changed the title
hvbtup
reviewed
Dec 16, 2025
Contributor
hvbtup
left a comment
hvbtup
left a comment
There was a problem hiding this comment.
I don't know if this routine can also be called for other types of URLs, eg file URLs.
I think the error body "No HTTP-Protocol" is useless and even misleading in this case.
extractErrorBody should only be called for HTTP protocols.
Author
|
@hvbtup valid point, i changed the pull-request |
hvbtup
approved these changes
Dec 17, 2025
Contributor
|
This seems fine. Could you please share what the resulting error looks like? |
Contributor
@mithrandirii Can you please respond? |
Contributor
|
Moved to 4.24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added response body to failed responses in ResourceLocatorWrapper #2334