Skip to content

Fix DependencyTrack API request method #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukpueh merged 1 commit into from
Mar 11, 2026
Merged

Fix DependencyTrack API request method #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ sequenceDiagram
IdP->>PIA: 7. Return JWKs
PIA->>PIA: 8. Authenticate
Note over PIA: - Verify token<br/>- Match claims with projects settings
PIA->>dp: 9. Post SBOM
PIA->>dp: 9. Upload SBOM
dp-->>PIA: Success
PIA-->>Publisher: Success
```
Expand Down Expand Up @@ -128,7 +128,7 @@ sequenceDiagram

- see 3.1.1. Token Verification and Authentication Flow

5. **SBOM Publishing**: PIA sends POST request to DependencyTrack:
5. **SBOM Publishing**: PIA sends upload request to DependencyTrack:

- `Content-Type`: `application/json`
- `X-Api-Key`: Use internally stored, DependencyTrack access token
Expand Down Expand Up @@ -194,7 +194,7 @@ Content-Type: application/json
- Issuer not allowed
- No matching project found for token claims
- `422 Unprocessable Entity`: Missing Authorization header or invalid JSON
- `502`: DependencyTrack post request failed
- `502`: DependencyTrack upload request failed
- `*`: Relay DependencyTrack status code


Expand Down
2 changes: 1 addition & 1 deletion pia/dependencytrack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def upload_sbom(
}

try:
response = requests.post(
response = requests.put(
url,
json=payload.to_dict(),
headers=headers,
Expand Down
14 changes: 7 additions & 7 deletions tests/test_dependencytrack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@ def dt_payload():


class TestUploadSBOM:
@patch("pia.dependencytrack.requests.post")
def test_upload(self, mock_post, dt_payload):
@patch("pia.dependencytrack.requests.put")
def test_upload(self, mock_put, dt_payload):
"""Test request and response."""
mock_post.return_value = "mock_response"
mock_put.return_value = "mock_response"
result = upload_sbom(TEST_URL, TEST_API_KEY, dt_payload)

# Assert result is request response
assert result == "mock_response"

# Assert request was made correctly
mock_post.assert_called_once_with(
mock_put.assert_called_once_with(
"https://dt.example.com/api/v1/bom",
json={
"projectName": "test-product",
Expand All @@ -51,10 +51,10 @@ def test_upload(self, mock_post, dt_payload):
},
)

@patch("pia.dependencytrack.requests.post")
def test_upload_request_exception(self, mock_post, dt_payload):
@patch("pia.dependencytrack.requests.put")
def test_upload_request_exception(self, mock_put, dt_payload):
"""Test error handling."""
mock_post.side_effect = requests.RequestException()
mock_put.side_effect = requests.RequestException()

with pytest.raises(
DependencyTrackError, match="Failed to upload SBOM to DependencyTrack"
Expand Down
Loading