Skip to content

Fixes openapi generator failing if property description is missing#15

Merged
thjaeckle merged 1 commit into
eclipse-ditto:mainfrom
thomas-fries-keen:thomas-fries-keen/fix_optional_description
Jun 29, 2026
Merged

Fixes openapi generator failing if property description is missing#15
thjaeckle merged 1 commit into
eclipse-ditto:mainfrom
thomas-fries-keen:thomas-fries-keen/fix_optional_description

Conversation

@thomas-fries-keen

Copy link
Copy Markdown
Contributor

On my first run, I was hit by exceptions, because of my tm had missing descriptions.

As description is not mandatory, I added this fix.

Also avoiding duplicate output of stacktrace

avoid duplicate output of stacktrace

Signed-off-by: thomas-fries-keen <thomas.fries@iqsight.com>

@thjaeckle thjaeckle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomas-fries-keen for the contribution.
Apparently we never noticed as we always have title and description.

Seems you do not yet have an Eclipse Account linked with the email-address you used for committing - or did not link the Eclipse account to the GitHub account yet?

Could you look into that please - so the "ECA" check passes ..

@thomas-fries-keen

Copy link
Copy Markdown
Contributor Author

Hi @thjaeckle,

should be ok now:

commit 1e5b6ca6dc3c94afa7dfe150c25bef0679d0111c (HEAD -> thomas-fries-keen/fix_optional_description, origin/thomas-fries-keen/fix_optional_description)
Author: thomas-fries-keen <thomas.fries@iqsight.com>
Date:   Fri Jun 26 11:25:51 2026 +0200

    fixes openapi generator failing if property description is missing
    avoid duplicate output of stacktrace
    
    Signed-off-by: thomas-fries-keen <thomas.fries@iqsight.com>

and thomas.fries@iqsight.com has a signed ECA in the eclipse account.

but I signed right after the PR. Can a re-check be triggered? Do I need to add another (empty) commit?

@thjaeckle thjaeckle added this to the 1.2.0 milestone Jun 29, 2026

@thjaeckle thjaeckle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomas-fries-keen thanks - I could re-validate - looks good now 👍

And the fix also looks good, thanks 👍

@thjaeckle
thjaeckle merged commit 0323eeb into eclipse-ditto:main Jun 29, 2026
3 checks passed
@thomas-fries-keen
thomas-fries-keen deleted the thomas-fries-keen/fix_optional_description branch June 29, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants