Skip to content

Handle bnd SNAPSHOT version-mismatch warnings centrally in the parent pom #26055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renatsaf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle bnd SNAPSHOT version-mismatch warnings centrally in the parent pom #26055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions nucleus/parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2322,6 +2322,42 @@
</resources>
</configuration>
</execution>
<!--
Compute bnd.version.mismatch.level used by the maven-bundle-plugin
_fixupmessages instruction (see below): 'ignore' for -SNAPSHOT builds,
'error' otherwise, so a release never ships a truncated SNAPSHOT package
version. regex-property does not overwrite an already-set property, so this
is done in two steps with a fresh property rather than a predefined default.
See issue #26004.
-->
<execution>
<id>bnd-version-mismatch-level-snapshot</id>
<phase>validate</phase>
<goals>
<goal>regex-property</goal>
</goals>
<configuration>
<name>bnd.version.mismatch.level</name>
<value>${project.version}</value>
<regex>.*-SNAPSHOT</regex>
<replacement>ignore</replacement>
<failIfNoMatch>false</failIfNoMatch>
</configuration>
</execution>
<execution>
<id>bnd-version-mismatch-level-release</id>
<phase>validate</phase>
<goals>
<goal>regex-property</goal>
</goals>
<configuration>
<name>bnd.version.mismatch.level</name>
<value>${bnd.version.mismatch.level}</value>
<regex>^(?!ignore$).+</regex>
<replacement>error</replacement>
<failIfNoMatch>false</failIfNoMatch>
</configuration>
</execution>
</executions>
</plugin>

Expand Down Expand Up @@ -2409,6 +2445,16 @@
<_include>-osgi.bundle</_include>
<_noimportjava>true</_noimportjava>
<_runee>JavaSE-21</_runee>
<!--
A package version derived from a Maven SNAPSHOT (e.g. 5.0.2-SNAPSHOT)
is not a valid OSGi version, so bnd truncates it (5.0.2) in the manifest
and reports a "Version for package ... set to different values" warning.
This is harmless during SNAPSHOT development but must not happen in a
release. Promote that warning to ${bnd.version.mismatch.level}, which is
'error' by default and relaxed to 'ignore' for -SNAPSHOT builds by the
build-helper regex-property executions above. See issue #26004.
-->
<_fixupmessages>"Version for package * is set to different values*";restrict:=warning;is:=${bnd.version.mismatch.level}</_fixupmessages>
</instructions>
</configuration>
</plugin>
Expand Down
Loading