Fix create-domain with a custom master password (Backport 7.x)#26087
Open
OndroMih wants to merge 4 commits into
Open
Fix create-domain with a custom master password (Backport 7.x)#26087OndroMih wants to merge 4 commits into
OndroMih wants to merge 4 commits into
Conversation
The problem was that the command expected the truststore file exists when setting a custom password. The fix is to set the password only if the truststore file exists (e.g. is part of the domain template), otherwise rely on creating the truststore when copying certificates from the keystore. I also fixed the case, when the provided password is too short. Keytool exists with 0 in that case and GlassFish failed later because the keystore wasn't created, without reporting any error about the password. Now the output contains an error message from keytool, such as: Invalid password, try again with a different password.( KeyTool command failed with exit code: 0 and output: Enter keystore password: Keystore password is too short - must be at least 6 characters Enter keystore password: Keystore password is too short - must be at least 6 characters Enter keystore password: Keystore password is too short - must be at least 6 characters Too many failures - try later )
- changeit is default JDK password for keystores Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
OndroMih
changed the title
OndroMih
changed the title
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26042 to branch
7.x./cc @dmatej