Skip to content

Extra Header Validation #26115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pandrex247 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Extra Header Validation #26115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...re/kernel/src/main/java/com/sun/enterprise/v3/services/impl/GlassfishNetworkListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021, 2025 Contributors to the Eclipse Foundation
* Copyright (c) 2021, 2026 Contributors to the Eclipse Foundation
* Copyright (c) 2007, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
Expand Down Expand Up @@ -60,6 +60,7 @@
import org.glassfish.hk2.utilities.BuilderHelper;
import org.glassfish.hk2.utilities.ServiceLocatorUtilities;
import org.glassfish.internal.grizzly.V3Mapper;
import org.glassfish.kernel.KernelLoggerInfo;
import org.jvnet.hk2.config.types.Property;

public class GlassfishNetworkListener extends GenericGrizzlyListener {
Expand Down Expand Up @@ -401,10 +402,19 @@ protected boolean onHttpHeaderParsed(final HttpHeader httpHeader,
final Buffer buffer,
final FilterChainContext ctx) {

final boolean result = super.onHttpHeaderParsed(httpHeader,
boolean result = super.onHttpHeaderParsed(httpHeader,
buffer, ctx);

final HttpRequestPacket request = (HttpRequestPacket) httpHeader;

// Here we can add extra validation to prevent Http Server invalid use of headers
if (request.containsHeader(Header.ContentLength) && request.containsHeader(Header.TransferEncoding)) {
KernelLoggerInfo.getLogger().log(Level.SEVERE,
"Can't use both headers Content-Length and Transfer-Encoding from the same request");
request.getProcessingState().setError(true);
result = true;
}

final HttpResponsePacket response = request.getResponse();

// Set response "Server" header
Expand Down
Loading