Make the remote maven listener a process in the launch#1706
Open
laeubi wants to merge 1 commit into
Open
Conversation
laeubi
force-pushed
the
make_remote_listener_an_own_process
branch
2 times, most recently
from
March 4, 2024 06:52
8f8bb67 to
716fa0d
Compare
laeubi
marked this pull request as ready for review
March 4, 2024 06:52
laeubi
force-pushed
the
make_remote_listener_an_own_process
branch
from
March 4, 2024 06:52
716fa0d to
4767cd5
Compare
laeubi
changed the title
laeubi
force-pushed
the
make_remote_listener_an_own_process
branch
from
March 4, 2024 07:44
4767cd5 to
7c19799
Compare
Currently m2e uses an additional socket connection to receive project events from the remote maven project. This is not visible to the user and requires some internal maps to maintain state. This refactors this into a more generic event facility and make it visible as a Process in the debug view, this also has the advantage that the process itself can be used to maintain the state.
laeubi
force-pushed
the
make_remote_listener_an_own_process
branch
from
March 4, 2024 07:44
7c19799 to
7024d55
Compare
Contributor
|
Would you please rebase this if you plan to finish it? |
Member
Author
|
Its still on my todo list... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently m2e uses an additional socket connection to receive project events from the remote maven project. This is not visible to the user and requires some internal maps to maintain state.
This refactors this into a more generic event facility and make it visible as a Process in the debug view, this also has the advantage that the process itself can be used to maintain the state.