Fix maxSpinThreads accounting in ObjectMonitor - #24405
Merged
Merged
Conversation
Replace the non-atomic check-and-increment of spinThreads with a compare-and-swap loop. This prevents concurrent threads from exceeding maxSpinThreads while reserving slots in the try-enter spin path and aligns the implementation with the corresponding OMR monitor fix. Related: eclipse-omr/omr#7878 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Contributor
Author
|
@keithc-ca Requesting your review. |
Contributor
|
Jenkins test sanity amac,plinux jdk25 |
Contributor
|
The failure in sanity.functional on ppc64le appears to be #24389. |
keithc-ca
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the non-atomic check-and-increment of
spinThreadswitha compare-and-swap loop.
This prevents concurrent threads from exceeding
maxSpinThreadswhile reserving slots in the try-enter spin path and aligns the
implementation with the corresponding OMR monitor fix.
Related: eclipse-omr/omr#7878