refactor: generate unique names/urls locally#1375
Conversation
|
@relu91 doesn't like adding " |
relu91
left a comment
There was a problem hiding this comment.
Ok for going with this direction, hoping then, in the future, we will have a more consistent way to generate URLs of afforndances! Thank you @danielpeintner !!!
There was a problem hiding this comment.
I am also fine with the direction :) Maybe we can refactor the code at some point in the future and move the "sluggification" to a central location to ensure a consistent naming scheme, but for now, this looks good to me :)
Edit: Or rather: Integrate the name clash avoidance into a common sluggification function.
Ah, sorry, I just noticed that that was actually the alternative in the other PR 😅 I have to apologize, I am only slowly getting back into the current set of issues and PRs at the moment. So I think avoiding duplication might still be worth considering in the future, but for now the current approach should work pretty well. |
|
Thank you for your comments! |
Yet another approach... (alternative for #1352)
Advantages I see:
fixes #1351