Skip to content

Pipeline Fix#76

Merged
egekorkan merged 3 commits into
eclipse-thingweb:mainfrom
bobur-khay:bugfix/failing_pipeline
Apr 1, 2026
Merged

Pipeline Fix#76
egekorkan merged 3 commits into
eclipse-thingweb:mainfrom
bobur-khay:bugfix/failing_pipeline

Conversation

@bobur-khay

Copy link
Copy Markdown
Contributor

Upgrading wot-typescript-definitions seems to have broken the tests. Adding no-experimental-strip-types to the .mocharc.yml file should fix that.

Comment thread package.json Outdated
@bobur-khay bobur-khay mentioned this pull request Mar 25, 2026
@egekorkan

Copy link
Copy Markdown
Member

I cannot see the error for some reason but copilot mentions node version incompatibility:

image

@bobur-khay

Copy link
Copy Markdown
Contributor Author

I can see it, but needing a maintainer to run the workflows is a little blocker:
image

@bobur-khay

Copy link
Copy Markdown
Contributor Author

needs a re-run

@codecov-commenter

codecov-commenter commented Mar 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.33%. Comparing base (0dd8275) to head (abbfde4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   69.33%   66.33%   -3.00%     
==========================================
  Files           1        1              
  Lines         300      300              
  Branches       79       79              
==========================================
- Hits          208      199       -9     
- Misses         70       79       +9     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bobur-khay bobur-khay force-pushed the bugfix/failing_pipeline branch from 7e43c43 to 8a5f2f5 Compare March 28, 2026 14:01
@bobur-khay

Copy link
Copy Markdown
Contributor Author

I have tried fixing the pipeline, fixing one issue creates another issue. And with waiting for maintainer approval to run every workflow to see if it is fixed it is becoming a little nerve-wracking. I reverted the last wot-typescript-definitions upgrade commit that broke it and if the upgrade is necessary a new ticket PR should be created with better upgrade planning.

@danielpeintner

Copy link
Copy Markdown
Member

I have tried fixing the pipeline, fixing one issue creates another issue. And with waiting for maintainer approval to run every workflow to see if it is fixed it is becoming a little nerve-wracking.

I think running & testing it on your own fork should work ...

@danielpeintner

Copy link
Copy Markdown
Member

Note: the current failing tests remind me of something we had in node-wot also but I currently fail to find the issue/PR

https://github.com/eclipse-thingweb/td-tools/actions/runs/23686799987/job/69011576505?pr=76#step:6:10

@bobur-khay

Copy link
Copy Markdown
Contributor Author

Should be fixed now

@bobur-khay bobur-khay force-pushed the bugfix/failing_pipeline branch from 23b3cba to 65f1709 Compare April 1, 2026 09:41
@egekorkan egekorkan merged commit 8e390db into eclipse-thingweb:main Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants