.github: do not push to tag on push to main - #8
Open
charludo wants to merge 2 commits into
Open
Conversation
thomasten
reviewed
Sep 2, 2026
| password: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Push versioned tag | ||
| if: ${{ !startsWith(github.ref, 'refs/tags/v') }} | ||
| run: nix run .#push -- "v$(cat version.txt)" |
Member
There was a problem hiding this comment.
Where is the versioned tag pushed on release?
Collaborator
Author
There was a problem hiding this comment.
We're currently doing it the other way around here, pushing a tag starts the release flow for that tag.
Member
There was a problem hiding this comment.
Sorry, I meant the tagged container push.
Collaborator
Author
There was a problem hiding this comment.
Ah, sorry. The publish workflow runs nix run .#render-k8s-resources, which calls `push-collateral-proxy "$tag". Yeah, maybe not the clearest naming 😄
Added a second commit that untangles push from rendering the resources.
thomasten
reviewed
Sep 2, 2026
Comment on lines
26
to
28
| - name: Push latest tag (main only) | ||
| if: github.ref == 'refs/heads/main' | ||
| run: nix run .#push -- latest |
Member
There was a problem hiding this comment.
Now that "on push branches main" is removed, this is always false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.