atls: invert the validator OID lookup logic #2484
Closed
burgerdev wants to merge 2 commits into
Closed
Conversation
This makes it easier to implement meta-validators, such as a validator composed of sub-validators or a list of acceptable alternative validators.
Member
Author
|
Ok, I learned now that the implementation with two functions does not work how I thought it would. I think I need a func Validate(context.Context, asn1.ObjectIdentifier, []byte, []byte) errorand dedicated errors for OID mismatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 2 teasered in #2483. I'd like to change the APIs in the
atlspackage to only work with a single validator and leave the logic of walking over the individual validators in thevalidatorspackage. For this to work, I need the interface to allow for the implementation to decide whether a given report can be processed, not theatlspackage. This PR changes the interface accordingly.