Skip to content

cli: don't add wildcard SAN - #2621

Merged
burgerdev merged 1 commit into
mainfrom
burgerdev/sans-no-asterisk
Sep 1, 2026
Merged

cli: don't add wildcard SAN#2621
burgerdev merged 1 commit into
mainfrom
burgerdev/sans-no-asterisk

Conversation

@burgerdev

@burgerdev burgerdev commented Sep 1, 2026

Copy link
Copy Markdown
Member

The plain wildcard SAN * can't be used with the majority of TLS implementations, which makes it ineffective for use outside the cluster where standard implementations (in particular, browsers) are usually used. Inside the cluster, where more permissive TLS libraries may be in use, its presence does more harm than good, considering that workloads may impersonate each other. Thus, don't add a plain * as SAN anymore.

Fixes CON-222.

@burgerdev
burgerdev requested a review from sespiros September 1, 2026 08:56
@burgerdev burgerdev added the breaking change A user-affecting breaking change label Sep 1, 2026
@linear-code

linear-code Bot commented Sep 1, 2026

Copy link
Copy Markdown

CON-222

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Do the documentation changes need to be backported?

Changes to /docs/docs won't be visible until the next release.
If you are fixing something in the docs that should be immediately visible, the changes needs to be made to both /docs/docs and /docs/versioned_docs/version-X.Y, where X.Y is the version of the latest minor release.
This can be done in this same PR.

  • Yes, this should be backported to the current version of the docs.
  • No, the PR only contains docs changes relevant for future versions.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-01 15:46 UTC

@sespiros sespiros left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had this commit as part of some other forgotten branch with "improvements" somewhere.

A couple of more stale docs/tests:

Comment thread docs/docs/architecture/components/manifest.md Outdated
The plain wildcard SAN '*' can't be used with the majority of TLS
implementations, which makes it ineffective for use outside the cluster
where standard implementations (in particular, browsers) are usually
used. Inside the cluster, where more permissive TLS libraries may be in
use, its presence does more harm than good, considering that workloads
may impersonate each other. Thus, don't add a plain * as SAN anymore.

Co-authored-by: Spyros Seimenis <sespiros@users.noreply.github.com>
@burgerdev
burgerdev force-pushed the burgerdev/sans-no-asterisk branch from e223d3a to a0550ea Compare September 1, 2026 13:11
@burgerdev

Copy link
Copy Markdown
Member Author

Addressed, thanks!

@burgerdev
burgerdev merged commit 4494a24 into main Sep 1, 2026
27 of 29 checks passed
@burgerdev
burgerdev deleted the burgerdev/sans-no-asterisk branch September 1, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A user-affecting breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants