Skip to content

Sync gramps@maintenance/gramps61 with upstream (2026-06-29) - #21

Closed
eduralph wants to merge 1 commit into
maintenance/gramps61from
sync/upstream-maintenance-gramps61-auto
Closed

Sync gramps@maintenance/gramps61 with upstream (2026-06-29)#21
eduralph wants to merge 1 commit into
maintenance/gramps61from
sync/upstream-maintenance-gramps61-auto

Conversation

@eduralph

Copy link
Copy Markdown
Owner

Automated nightly sync from gramps-project/gramps@maintenance/gramps61. Generated by .github/workflows/upstream-sync.yml on the testbed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f8e1c5024

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread po/zh_CN.po Outdated
#, python-format
msgid "FamilySearch search failed (HTTP %(status)s)."
msgstr "FamilySearch 更新失败(来源相关)。"
msgstr "FamilySearch 搜索失败(HTTP %(status))。"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the status placeholder conversion

This translated python-format string drops the s conversion from %(status)s, leaving %(status), so the Chinese catalog no longer passes validation: I checked msgfmt -c -o /dev/null po/zh_CN.po and it fails with “not a valid Python format string”. Any build/install step that compiles translations, and any runtime formatting of this message in zh_CN, will fail unless the placeholder is kept as %(status)s.

Useful? React with 👍 / 👎.

@eduralph
eduralph force-pushed the sync/upstream-maintenance-gramps61-auto branch 8 times, most recently from 9c484fe to e9c9230 Compare July 7, 2026 07:27
@eduralph
eduralph force-pushed the sync/upstream-maintenance-gramps61-auto branch from e9c9230 to cffdbff Compare July 8, 2026 06:21
@eduralph eduralph closed this Jul 8, 2026
@eduralph
eduralph deleted the sync/upstream-maintenance-gramps61-auto branch July 8, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant