Sync gramps@maintenance/gramps61 with upstream (2026-06-29) - #21
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f8e1c5024
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #, python-format | ||
| msgid "FamilySearch search failed (HTTP %(status)s)." | ||
| msgstr "FamilySearch 更新失败(来源相关)。" | ||
| msgstr "FamilySearch 搜索失败(HTTP %(status))。" |
There was a problem hiding this comment.
Preserve the status placeholder conversion
This translated python-format string drops the s conversion from %(status)s, leaving %(status), so the Chinese catalog no longer passes validation: I checked msgfmt -c -o /dev/null po/zh_CN.po and it fails with “not a valid Python format string”. Any build/install step that compiles translations, and any runtime formatting of this message in zh_CN, will fail unless the placeholder is kept as %(status)s.
Useful? React with 👍 / 👎.
9c484fe to
e9c9230
Compare
e9c9230 to
cffdbff
Compare
Automated nightly sync from
gramps-project/gramps@maintenance/gramps61. Generated by .github/workflows/upstream-sync.yml on the testbed.