Sync gramps@master with upstream (2026-07-02) - #22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 522c07b4b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| filt = self.filt.find_filter() | ||
| if filt: | ||
| for handle in filt.apply(db, user=user): | ||
| person = db.get_raw_person_data(handle) |
There was a problem hiding this comment.
Load matched people as Person objects
When a referenced subfilter matches at least one person, this passes db.get_raw_person_data(handle) into init_ancestor_list; for the default DBAPI/DbGeneric backends that method returns serialized raw data, not a Person. init_ancestor_list immediately reads person.handle and parent_family_list, so these *FilterMatch relationship filters crash instead of evaluating (the same raw-person pattern appears in the sibling/parent/child/descendant variants). Fetch the object with get_person_from_handle(handle) before calling the existing helper.
Useful? React with 👍 / 👎.
fd299ba to
f92ce2b
Compare
f92ce2b to
e942ec2
Compare
Automated nightly sync from
gramps-project/gramps@master. Generated by .github/workflows/upstream-sync.yml on the testbed.