Skip to content

Sync gramps@master with upstream (2026-07-02) - #22

Closed
eduralph wants to merge 1 commit into
masterfrom
sync/upstream-master-auto
Closed

Sync gramps@master with upstream (2026-07-02)#22
eduralph wants to merge 1 commit into
masterfrom
sync/upstream-master-auto

Conversation

@eduralph

@eduralph eduralph commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Automated nightly sync from gramps-project/gramps@master. Generated by .github/workflows/upstream-sync.yml on the testbed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 522c07b4b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

filt = self.filt.find_filter()
if filt:
for handle in filt.apply(db, user=user):
person = db.get_raw_person_data(handle)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Load matched people as Person objects

When a referenced subfilter matches at least one person, this passes db.get_raw_person_data(handle) into init_ancestor_list; for the default DBAPI/DbGeneric backends that method returns serialized raw data, not a Person. init_ancestor_list immediately reads person.handle and parent_family_list, so these *FilterMatch relationship filters crash instead of evaluating (the same raw-person pattern appears in the sibling/parent/child/descendant variants). Fetch the object with get_person_from_handle(handle) before calling the existing helper.

Useful? React with 👍 / 👎.

@eduralph
eduralph force-pushed the sync/upstream-master-auto branch 5 times, most recently from fd299ba to f92ce2b Compare July 7, 2026 07:27
@eduralph
eduralph force-pushed the sync/upstream-master-auto branch from f92ce2b to e942ec2 Compare July 8, 2026 06:21
@eduralph eduralph closed this Jul 8, 2026
@eduralph
eduralph deleted the sync/upstream-master-auto branch July 8, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant