feat(gates): gate-promotion lifecycle — list advisory checks ready to promote - #157
Merged
Conversation
… to promote (#156) Promoting a check from advisory (gating=false) to gating was a manual flip with no signal for WHEN it's earned. A check may now carry promote_after=N: gates.promotion_candidates() scans frozen cycles and returns each advisory check that has PASSED in its N most-recent frozen runs. `pdca gates --promotions` lists them — hint-only, the human flips `gating` (nothing is auto-mutated). De-risks a new (often Act-proposed) gate, which should prove itself advisory before it blocks. Documented in pdca.toml + docs/05. Adds test_gate_promotion.py (6 cases). Suite 282 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7084705e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…SUMMARY date Codex review (#157): _signoff_date searched the whole SUMMARY.md for the first ISO date, but assembled summaries carry brief/reviewer dates in §1/§5 before §9. A newer failing cycle could sort behind older passing ones, reporting a check ready though its most-recent sign-off run failed. Scope the date to the §9 'Check sign-off' section (as the act parsers do). Adds a regression test (newest cycle fails, has an old §1 date). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156.
Promoting a check from advisory (
gating = false) to gating is a manual flip inpdca.toml, with no signal for when it's earned — so a new (often Act-proposed) gate either blocks every cycle on day one, or never gets promoted.A check may now carry
promote_after = N.gates.promotion_candidates()scans frozen cycles (newest-first by §9 date) and returns each advisory check that has passed in its N most-recent runs — earned promotion.pdca gates --promotionslists them. Hint-only: the human flipsgating = true; nothing is auto-mutated.gates.py:promotion_candidates()(+check-gates.jsonreaders).cli.py:pdca gates --promotions.pdca.tomlGATING-POLICY note + docs/05.test_gate_promotion.py(6 cases: ready at threshold, recent fail / unverifiable breaks it, below threshold, gating/no-promote_after excluded).Suite 282 green.
🤖 Generated with Claude Code