refactor(signoff): unify discontinue naming — park → discontinue (#48) - #50
Merged
Conversation
The `park` disposition (#42) named one feature three inconsistent ways: the terminal state was DISCONTINUED, the documented intent "discontinue", but the action/flag/outcome tokens were park/--park/parked — which also collided in spelling with the PARKED halt-set (states the driver stops at). Rename the disposition to one word across action → outcome → state: discontinue (action/flag) → discontinued (outcome) → DISCONTINUED (state). Clean rename: --park/parked dropped entirely (no alias, no legacy tolerance — no known bundle carries the parked outcome yet). The PARKED halt-set is renamed HALTED so "park" disappears from the codebase. Closes #48 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
parkdisposition (#42) named one feature three inconsistent ways: the terminal state wasDISCONTINUED, the documented intent "discontinue", but the action/flag/outcome tokens werepark/--park/parked— which additionally collided in spelling with thePARKEDhalt-set (the states the driver stops at, incl.COMPLETE).This unifies the disposition on one word across action → outcome → state:
discontinue(action/flag) →discontinued(outcome) →DISCONTINUED(state).Per the issue's deferred decisions:
--park/parkeddropped entirely (no hidden alias, no legacyparkedtolerance; no known bundle carries theparked§9 outcome yet).PARKEDhalt-set →HALTEDso the word "park" disappears from the codebase entirely.Changes
leaves.py(VALID_DECISIONS+ prompt),signoff.py(VALID_OUTCOMES,ACTION_TO_OUTCOME),state.py(_OUTCOME_TO_STATEkey),cli.py(--park→--discontinue).state.pyPARKED→HALTED,driver.py.queue.py,flow.py,cli.py("parked state" → "halted state").02-cycle-artifacts.md,03-cycle-automation.md.test_driver_slice.py,test_flow_slice.py,test_gates_unverifiable.py.Verification
python3 -m unittest discover -s tests→OK).grep -rniE "park" template/→ no hits.pdca signoff --helpshows--discontinue, no--park.Closes #48
🤖 Generated with Claude Code