Skip to content

feat: course-discovery clones edx fork #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iloveagent57 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

feat: course-discovery clones edx fork #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfiles/course-discovery.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ RUN nodeenv ${DISCOVERY_NODEENV_DIR} --node=16.14.0 --prebuilt && npm install -g
WORKDIR ${DISCOVERY_CODE_DIR}

# Cloning git repo
RUN curl -L https://github.com/openedx/course-discovery/archive/refs/heads/master.tar.gz | tar -xz --strip-components=1
RUN curl -L https://github.com/edx/course-discovery/archive/refs/heads/master.tar.gz | tar -xz --strip-components=1

Comment on lines 69 to 71
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build step downloads and untars the repository from a moving target (master) without any integrity check. That makes image builds non-reproducible and increases supply-chain risk (the contents can change without any Dockerfile change). Consider pinning to a specific tag or commit SHA and verifying a checksum/signature; also prefer curl -fSL --retry ... (and failing the build on HTTP errors) to avoid piping unexpected content into tar.

Copilot uses AI. Check for mistakes.
RUN npm install --production && ./node_modules/.bin/bower install --allow-root --production && ./node_modules/.bin/webpack --config webpack.config.js --progress

Expand Down
Loading