fix: Apply security, performance & CI improvements (fixes #4, #1)#5
Merged
Conversation
- Create team roster (Neo, Trinity, Agent Smith, Morpheus, Scribe, Ralph) - Establish routing rules and decision ledger - Seal agent charters and history files The team is hired and ready to work on ElBruno.HuggingFace.Downloader. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Security improvements: - Add URL validation in HuggingFaceUrlBuilder to prevent path traversal attacks - Validate RepoId, FilePath, and Revision parameters - Remove repo ID and URLs from error messages to prevent information leakage - Add null check for options in constructor Performance optimizations: - Pre-allocate list capacity based on required/optional file counts - Improve HttpClient creation with explicit buffer size naming - Clear and set UserAgent headers properly to avoid duplicates Reliability improvements: - Add timeout validation with ArgumentOutOfRangeException - Improve null checks in private constructor - Better error messages without exposing sensitive information Fixes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two critical issues and applies important improvements to the library:
🔐 Security Enhancements (Issue #4)
⚡ Performance Optimizations (Issue #4)
🔧 Reliability Improvements (Issue #4)
📚 Documentation (Issue #1)
Technical Details
Files Modified:
Testing:
Checklist
Related Issues
Fixes #4 (Apply security, performance & CI lessons from LocalEmbeddings v1.1.0 audit)
Fixes #1 (Add ElBruno.PersonaPlex to Related Projects in README)
Squad Notes
Ready for review and merge!