Allow variable body for fileRequest()#199
Open
CorrectRoadH wants to merge 1 commit into
Open
Conversation
fileRequest() sends a file as the request body, so its body argument should accept a variable (e.g. a file reference) rather than requiring a literal dictionary. Loosen the body parameter from `dictionary!` to `variable` to match how the action is actually used. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Xvr9ByAkYxnM3SJjBw9T9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #192 as an unrelated change.
fileRequest()sends a file as the request body, so itsbodyargument should accept a variable (e.g. a file reference) rather than requiring a literal dictionary. This loosens thebodyparameter fromdictionary!tovariableto match how the action is actually used.Verified with
go build ./...andgo test -run TestCherriNoSign.